FIXED: Get all custom fields the right way!

This is in /models/post.php

Thanks for this Chris.. I was dreading the taunting task of inputting each custom field.

Chris – I changed my set_custom_fields_value(){} in the /models/post.php and I’m still not seeing my custom fields – any ideas?

I didn’t quite understand what this means:

Now you can pass in either { * | true | all } and retrieve all of your custom fields.
Any of these will work
?json=true&custom_fields=*
?json=true&custom_fields=true
?json=true&custom_fields=all

I didn’t know where to put this in the original code. So I used your serialized arrays code but I’m not using serialized arrays in my custom fields.

This only checks for a serialized array in your custom field but doesn’t affect anything if it doesn’t exist.

You should just overwrite the set_custom_fields_value(){ … }
with the one above and you should be able to pass custom_fields=all to get all your custom fields

There really isn’t anything different about the way you get custom_fields from the way it was done originally. You can just retrieve all of your custom fields at one time without having to pass which custom fields you want like the old way.

OLD WAY:
https://myurl.com/?json=true&custom_fields=_my_var_1,_my_var_2,_my_var_2

NEW WAY
https://myurl.com/?json=true&custom_fields=all

Now I get it! It worked! Thanks Chris!

@chris_mcclellan Any chance you can re-post that snippet somewhere else, as it appears that codepad.org is down.

I’m getting an error with this line:

$this->custom_fields->$key->$sub_key = $sub_val;

So I’m curious to see if you’ve made an update to address that.

I’m using this one now which just adds the custom fields every time – this way its less string manipulation I have to perform at any given point. This works for me… and does not address that line you posted.

// Updated <code>set_custom_fields_value()</code> to retreive all fields properly
	function set_custom_fields_value() {

		global $json_api;

		// Query string params for this query var
		$params = trim($json_api->query->custom_fields);
		$wp_custom_fields = get_post_custom($this->id);
		$this->custom_fields = new stdClass();

		// Loop through our custom fields and place on property
		foreach($wp_custom_fields as $key => $val) {

			if ( $val ) {

				// Some fields are stored as serialized arrays.
				// This method is not recursive. Does not support multidimensional arrays.
				$current_custom_field = @unserialize($val[0]);

				if (is_array($current_custom_field)) {

					// Loop through the unserialized array
					foreach($current_custom_field as $sub_key => $sub_val) {

						// Lets append these for correct JSON output
						$this->custom_fields->$key->$sub_key = $sub_val;
					}

				} else {

					// Break this value of this custom field out of its array
					// and place it on the json blob like usual
					$this->custom_fields->$key = $val[0];

				}
			}
		}

	}

@chris_mcclellan: Hmmmm, I’m getting this error from that code:

Warning: Creating default object from empty value in /wp-content/plugins/json-api/models/post.php on line 286

… which is:

$this->custom_fields->$key->$sub_key = $sub_val;

Thoughts?

You could try… Sorry i’m at work so I can’t test it.

$this->custom_fields->$key[$sub_key] = $sub_val;

I don’t get an error on get_recent_posts, but when I try to also list custom post types, I’mg getting the error (still).

hmmm. I’ll give it a look when I get home.
It should work as there are only minor changes on the original code base.

FIXED. Now this returns the array correctly… ugh that should have been the solution from the beginning.

ENJOY!

// Updated <code>set_custom_fields_value()</code> to retreive all fields properly
	function set_custom_fields_value() {

		global $json_api;

		// Query string params for this query var
		$params = trim($json_api->query->custom_fields);
		$wp_custom_fields = get_post_custom($this->id);
		$this->custom_fields = new stdClass();

		// Loop through our custom fields and place on property
		foreach($wp_custom_fields as $key => $val) {

			if ( $val ) {

				// Some fields are stored as serialized arrays.
				// This method is not recursive. Does not support multidimensional arrays.
				$current_custom_field = @unserialize($val[0]);

				if (is_array($current_custom_field)) {

					// This item is an array - lets append it as such
					$this->custom_fields->$key = $current_custom_field;

				} else {

					// Break this value of this custom field out of its array
					// and place it on the json blob like usual
					$this->custom_fields->$key = $val[0];

				}
			}
		}
	}

Hey Chris, great plugin. Thanks for the custom function up there.

Any chance you’ll merge this into a new release soon?