[Plugin: WordPress Social Login]
-
Hi,
There is an issue with w3c validation with the attribute “provider” on A tag.
I suggest to make this attribute an url hash.
in includes/plugin.ui.php, instead of :
<a href="javascript:void(0)" provider = "" title="Connect with <?php echo $provider_name ?>" class="wsl_connect_with_provider" >
I suggest that:
<a href="#<?php echo $provider_id ?>" title="Connect with <?php echo $provider_name ?>" class="wsl_connect_with_provider" >
moreever javascript:void(0) is not correct and you mays prefer event.preventDefault() in click event function and modify the first function in asset/js/connect.js like this:
(function($) { $(function(){ $(".wsl_connect_with_provider").click(function(){ popupurl = $("#wsl_popup_base_url").val(); provider = this.hash; provider = provider.substring(1, provider.length) window.open( popupurl+"provider="+provider, "hybridauth_social_sing_on", "location=1,status=0,scrollbars=0,width=800,height=600" ); event.preventDefault(); }); }); })(jQuery);
Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
- The topic ‘[Plugin: WordPress Social Login]’ is closed to new replies.