[Plugin: SB Welcome Email Editor] Broken for wp 3.1

Had the same problem when I try to edit another plugin and had to delete the plugin completely.

Did you find another plugin that works? If so, please share the name.

This is the line of code that is causing the issue, but I am not sure what this does, any ideas?

if(!ereg( get_option($welcome_http_host), $_SERVER[‘HTTP_REFERER’])){

Did you edit the code of the plugin?

Hi Guys,

I just spotted this thread so apologies for my late input. I don’t know what plugin you are using but it isn’t mine. I don’t use ereg generally and I have just checked the version 1.4 code and there is no reference to it. Can I ask where you got the plugin from, the extend directory or somewhere else?

@portlandridge: Don’t know if you renamed the plugin file but my plugin is in a directory called welcome-email-editor and the filename is sb_welcome_email_editor.php

Feel free to get me via email (barton.sean[at]gmail.com) or reply on here and I will look into any issues you guys are having.

thanks
Sean

Hi again, just released a new version which should be more stable. Moved to wp_mail from mail and using the appropriate WP filters to amend the from address and names. I just tested with WP3.1 and all is fine.

cheers
S

Just downloaded and installed the latest version of the SB Welcome Email plugin on a WordPress 3.1.3 multisite install.

It looks fine if you send a test email, but if you actually register you still get the same old BS email.

I am using a customized registration process based on WPMU and Buddypress. That could be part of the problem, but many potential users of this plugin will be in a similar situation.

I have no clue how to troubleshoot this. I used to have my own fix hardcoded in wpmu-functions.php, but I think that file is no longer there. Any help appreciated.

Why the %#!@ is it still impossible in WordPress to edit the welcome email?!

Automattic only seems to listen to code hobbyists. They are absolutely horrible where it comes to end-user interface and just general common sense. I’m really sick of having to waste time on this issue every time I upgrade a site.

Hi there, I completely agree that this sort of thing should be built in but I suppose plugins exist to do it so there isn’t a great deal of point ??

My plugin should in theory work with Multisite but I can’t say I have spent much time looking at it. I do know, however, that buddypress does actually have this functionality inbuilt but without the editor as far as I know. If you grep the buddypress code for wp_new_user_notification then remove or rename the function then my plugin should work.

This is a constant issue for me as well as often plugins either declare their own versions of the function or cause the WordPress one to be declared.

Good luck. Let me know if you need any help.

thanks
Sean

Thanks for the quick response.

I found my custom code solution again. It’s an edit in function wpmu_welcome_user_notification in ms-functions.php – that file is still there after all.

Where does that function fit it? Where is it “called” in the registration process? Should I replace it with something else so I can use the excellent-looking SB Welcome Email plugin?

Buddypress has been a constant source of frustation for me as well. At one point they changed all the template tags, making it pretty much impossible for me to upgrade my heavily customized theme.

BP development was going off the rails anyway imho, so I’m phasing it out, but I still have too much code that depends on BP.

Ok I see. Just had a look at the code and in theory I could add support but not right away. If you wanted to have a go at filtering it then it might work if not watch out for the next version of the plugin where I will get it integrated for you.

You need to do add_filter(‘wpmu_welcome_user_notification’, ‘wp_new_user_notification’, 10, 3); somewhere in your theme which might well work. It should cause the site to ignore the WPMU welcome email code and use the standard WordPress one instead… at least that’s the intention.

As I say if you get it to work then let me know, otherwise I shall try and get it added asap for you.

thanks
Sean

Thanks!

I’ve tried adding the filter. It does change the welcome email to the version from your plugin, but the firstname + lastname tags no longer work.

For now I’ll go back to my edit in ms-functions.php, where I added this:

$fullname = $meta[field_1];

and

$welcome_email = str_replace( "FULLNAME", $fullname, $welcome_email );

So I can use FULLNAME in the regular WP email editor.

I’d prefer a plugin for this though.

Or can I create a custom function in my theme’s functions.php and then use an add_filter line like the one you gave me to redirect a call to wpmu_welcome_user_notification() to that function?

Hi,

Yep you could use your own method of course. Or modify my plugin… If you go into the code within my plugin and look for the declaration of the wp_new_user_notification function then simply add a third argument ($meta) and add your replaces in there then you could use my admin system. Frankly it won’t take me long to make my plugin multisite compatible. Will look to get it done in the next week or two if you would be so kind as to test it for me. I would like to be able to offer additional hooks and some granularity for multisite users so need to put some thought into it. Am at barton [dot] sean [at] gmail [dot] com if you want to go over it some more.

thanks
Sean