Deprecation Notice on PHP 8.1

  • Resolved gyfdeveloper

    (@gyfdeveloper)


    3 months ago

    I see this plugin has not been tested on recent WordPress installs, so I’m not sure how active the development still is. While upgrading some server software, I checked the debug logs and saw a deprecation notice on the use of FILTER_SANITIZE_STRING in /login-recaptcha/login-nocaptcha.php on line 106.

    It’s also preventing logging in under some circumstances. This is for PHP 8.1. We use this plugin on many client sites and would love to continue using if the development team is still working on the plugin.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Robert Peake

    (@robertpeake)

    This plugin is being maintained for bug fixes and essential enhancements. It is working well for many sites under php 8.x. If you would like to submit a pull request for string sanitization using an updated method, you can do so here: https://github.com/cyberscribe/login-recaptcha/

    Thread Starter gyfdeveloper

    (@gyfdeveloper)

    Respectfully, I’m not sure why you feel we should do the work for you. Just because it *does* work for many sites using PHP 8+ doesn’t mean it’s working for all of them. We are an SEO agency first and foremost, not a development firm.

    When I see a plugin is untested on current versions of WordPress and breaks in some circumstances on a modern PHP version, red flags go up. We’ll continue using the plugin on older installs, but I’m disabling it on sites using 8.1+.

    Plugin Author Robert Peake

    (@robertpeake)

    That’s fine. Enjoy using this free open source software to the extent that it is useful to you. It is made entirely by volunteers in our spare time. So, one way to show your respect for the hard work and dedication that goes into making something like this is to contribute to the code base when you see an opportunity for improvement. That was the spirit of my invitation.

    Thread Starter gyfdeveloper

    (@gyfdeveloper)

    As a developer myself, I fully understand the time and energy put into open source projects (I have several spanning 5+ years), but normally when someone reports a bug in the software, the right thing to do from a customer service perspective is to say you’ll look into the problem and apply a patch, not tell the reporting party that they can fix it themselves.

    I’m not paid to maintain your software for you. Do I think it would be fun to play around with the code a bit? Sure, but that’s not the point. We have dozens of client websites using this plugin, and in the event we get locked out of any of them because of bugs in the software, that is time and money lost for our company, as well as our clients.

    I hope I’m not coming off as rude; I just think this could have been handled better from your end.

    Thread Starter gyfdeveloper

    (@gyfdeveloper)

    We’ve now had two sites on PHP 7.4 and 8.0, respectively, that generate an “incorrect recaptcha, please try again” error which does not go away when reloading the page. Since this bug report has gone nowhere, we will be disabling the plugin on all client sites.

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.

Tags