Check for HTTP_USER_AGENT?

  • Resolved Mike Witt

    (@mike80222)


    5 months ago

    Hi,

    I feel like there should be a check in wp-quicklatex.php, around line 1719, for HTTP_USER_AGENT. Maybe something like:

    // Do not count bots since they are not users and we are looking for user experience.
    if ( isset($_SERVER['HTTP_USER_AGENT']) ) { $agent = strtolower($_SERVER['HTTP_USER_AGENT']); }
    else { $agent = 'Unknown'; }

    This would avoid PHP complaints like:

    PHP Notice: Undefined index: HTTP_USER_AGENT in /opt/bitnami/apps/wordpress/htdocs/wp-content/plugins/wp-quicklatex/wp-quicklatex.php on line 1719

    Does that make any sense?

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author advanpix

    (@advanpix)

    Yes, absolutely. I have included your fix into the newest version (released a few minutes ago). Please test it now.

    Thread Starter Mike Witt

    (@mike80222)

    Hi @advanpix,

    Sorry about the delay. As far as “testing” it, the warning is only going to happen once in a while. But the change in 3.8.8 looks equivalent to the patch I’ve been using for a long time. So AFAICT that’s good.

    It’s nice to see wp-quicklatex getting updated. (Not that I’d want to see a lot of updates!) But nice to know that it’s still alive.

    Cheers,

    Mike

Viewing 2 replies - 1 through 2 (of 2 total)
  • You must be logged in to reply to this topic.