Multiply adding the same scripts and styles

  • Resolved Alexander Guskov

    (@forcesail)


    1 year, 5 months ago

    Hello and thanks for the plugin.

    If there are a few [expand_makers] shortcodes on a page, methods ReadMoreIncludeManager::buttonContent() and ReadMoreIncludeManager::includeScripts() add as many script and style blocks as many [expand_makers] shortcodes on a page.

    It makes page bigger and can conflict js-scripts (and make rendering page slower). Please fix it.

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author edmon.parker

    (@edmonparker)

    Dear @forcesail,

    Please update plugin to the latest version, in that version we did improvement.

    hi read more team there’s a critical issue with read more plugin. After updating latest version I’m unable to edit my posts. When trying to create or edit post “There has been a critical error on this website. Please check your site admin email inbox for instructions” appearing in the screen.

    Plugin Author edmon.parker

    (@edmonparker)

    Dear @strangeuser134,

    We made a change and here I am sending you a modified version
    https://we.tl/t-40qXvENgW0
    Please uninstall your current version and install this one.

    If it’s not affected please enable WordPress debug mod from WordPress wp-config.php that can help us to see the Error.

    looking forward to your reply

    Plugin Author edmon.parker

    (@edmonparker)

    Please use this one?https://we.tl/t-wTd5mG7oIH
    Please check and let me know about your progress.

    Thread Starter Alexander Guskov

    (@forcesail)

    Hello.

    I have updated to v.3.2.6.1 and don’t meet the critical issue, described by @strangeuser134 neither that the topic issue has fixed.

    So, nothing has changed, I still have as many the similar <style> and <script> blocks as many [expand-maker] shortcodes on the page.

    You can enjoy it by yourself here:
    https://forcesail.ru/%d1%8f%d1%85%d1%82%d1%88%d0%ba%d0%be%d0%bb%d0%b0/

    Plugin Author edmon.parker

    (@edmonparker)

    Dear @forcesail,

    Could you please mention which scripts and styles are duplicated on your website? and when you add new read more it’s include new script?

    Please the first clear your browser cache also, because we did improvements and now readMoreArgs where we have read more settings now are unique per read more.

    If you give more detailed information, we will be happy to improve them

    Thread Starter Alexander Guskov

    (@forcesail)

    I see a lot of pairs of styles for .yrm-toggle-expand-3 on line 744 of the page mentioned above and the some number of scripts with the same code.

    I believe you can check it by yourself getting inside of https://forcesail.ru/%d1%8f%d1%85%d1%82%d1%88%d0%ba%d0%be%d0%bb%d0%b0/

    All caches are currently off.

    Plugin Author edmon.parker

    (@edmonparker)

    Dear @forcesail,

    Could you please try this modified version https://we.tl/t-G4pkrsrkGb
    If it’s ok, it will be included in our upcoming update.

    Looking forward to your reply

    Thread Starter Alexander Guskov

    (@forcesail)

    Dear @edmonparke,

    I have tested the last modified version and it looks it works fine.

    As you have significantly improved this block of code, probably you would join all descriptions the same class to one and join <style></style> to one (for example, currently plugin generates 5 css descriptions of .yrm-toggle-expand-3 class in 5 <style></style> blocks) .

    Actually we are fighting for site performance ??

    Plugin Author edmon.parker

    (@edmonparker)

    Dear @forcesail,


    Thank you for your reply, we will do that on our upcoming update.
    If you will have any new feature suggestions also, please write here in support forum and we will be happy

    Thanks.

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Multiply adding the same scripts and styles’ is closed to new replies.