Bug with ESI block
-
Hi,
I’m getting an intermittent issue with an ESI block that I’ve implemented on my staging site where instead of inserting the defined HTML tag, Litespeed instead inserts the whole page HTML again which is obviously causing the page to break apart completely. The issue is only resolved by Purging my LS cache.
This is my ESI block defined in my filters.php file:
function esi_postcode_form_block_esi_load($params) { #do_action( 'litespeed_control_set_ttl', 300 ); do_action( 'litespeed_control_set_nocache' ); echo sprintf('<input id="%s" type="text" class="%s %s postcode" data-search_postcode="%s" disabled />', $params['id'], $params['classes'], $params['type']==='size'?'tyre-size':'reg', WC()->session->get('search_postcode')); } add_action( 'litespeed_esi_load-esi_postcode_form_block', '\App\esi_postcode_form_block_esi_load' );As you can see, I’m just setting it to not be cached.
Then in my shortcode I’m inserting this ESI like this:
if(is_plugin_active('litespeed-cache/litespeed-cache.php')){ $size_postcode_field = apply_filters('litespeed_esi_url', 'esi_postcode_form_block', 'Postcode form block', ['id' => sprintf('sc-fbf-reg-tyre-search--%s-postcode_%s', 'size', $id), 'type' => 'size', 'classes' => 'sc-fbf-reg-tyre-search__form-field']); }else{ ... } $html = <<<HTML <div class="fbf-form-group sc-fbf-reg-tyre-search__form--row"> {$size_postcode_field} </div> HTML; return $html;When it goes wrong the page looks like this:
And looking at the Inspector in Firefox developer console, the HTML looks like this:
As you can see above, where the
Postcode form blockbegins, instead of just inserting the HTML for the input, it’s inserting the full HTML of the page – again.Could someone have a look at this for me please as obviously I can’t put this live with this issue present.
Many thanks
Kevin
The page I need help with: [log in to see the link]
-
@qtwrk – I installed v5.7-a17 yesterday on the staging site – https://staging.4x4tyres.co.uk and it ran ok, but this morning when I’ve looked at it it’s broken again, so sorry to report but the bugfix does not seem to be working.
In order to try and help you resolve this, I buried deep into the repeated HTML and where the ESI block should be in the repeated page I found this:
As you can see, where the field should be it says
[an error occured while processing this directive]– I’ve checked for PHP errors though and I’m not seeing anything.Appreciate you looking into this for me.
@hailite – that code is on line 501 in the dev version of the plugin, is that correct?
Just to note, in order to get the code change to show up, I had to purge the litespeed cache, so obviously that fixes the issue anyway.
So now the html is showing up as:
I’ve looked in the log and all I can see is POST request to `/wp/wp-admin/admin-ajax.php:
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] ?? ------POST HTTP/1.1 (HTTPS) /wp/wp-admin/admin-ajax.php
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] Query String:
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] HTTP_REFERER: https://staging.4x4tyres.co.uk/tyre-search/
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/116.0
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] Accept: application/json, text/javascript, */*; q=0.01
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] Accept Encoding: gzip, deflate, br
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] Cookie _lscache_vary: guest_mode:1
09/14/23 15:39:49.133 [213.246.156.82:56053 1 ohB] X-LSCACHE: true
09/14/23 15:39:49.134 [213.246.156.82:56053 1 ohB] [ESI] Overwrite wp_create_nonce()
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] ?? ------POST HTTP/1.1 (HTTPS) /wp/wp-admin/admin-ajax.php
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] Query String:
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] HTTP_REFERER: https://staging.4x4tyres.co.uk/tyre-search/
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/116.0
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] Accept: application/json, text/javascript, */*; q=0.01
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] Accept Encoding: gzip, deflate, br
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] Cookie _lscache_vary: guest_mode:1
09/14/23 15:39:49.137 [213.246.156.82:56053 1 6rk] X-LSCACHE: true
09/14/23 15:39:49.138 [213.246.156.82:56053 1 6rk] [ESI] Overwrite wp_create_nonce()
09/14/23 15:39:49.278 [213.246.156.82:56053 1 6rk] ?? No cache due to Admin page
09/14/23 15:39:49.278 [213.246.156.82:56053 1 ohB] ?? No cache due to Admin page
09/14/23 15:39:49.318 [213.246.156.82:56053 1 6rk] [Media] init
09/14/23 15:39:49.318 [213.246.156.82:56053 1 6rk] [LQIP] init
09/14/23 15:39:49.318 [213.246.156.82:56053 1 6rk] [CDN] init
09/14/23 15:39:49.318 [213.246.156.82:56053 1 6rk] ? Init
09/14/23 15:39:49.319 [213.246.156.82:56053 1 6rk] [Router] LSCWP_CTRL bypassed empty
09/14/23 15:39:49.320 [213.246.156.82:56053 1 ohB] [Media] init
09/14/23 15:39:49.321 [213.246.156.82:56053 1 ohB] [LQIP] init
09/14/23 15:39:49.321 [213.246.156.82:56053 1 ohB] [CDN] init
09/14/23 15:39:49.321 [213.246.156.82:56053 1 ohB] ? Init
09/14/23 15:39:49.321 [213.246.156.82:56053 1 ohB] [Router] LSCWP_CTRL bypassed empty
09/14/23 15:39:49.427 [213.246.156.82:56053 1 6rk] [Core] CHK html bypass: miss footer const
09/14/23 15:39:49.427 [213.246.156.82:56053 1 6rk] [Ctrl] not cacheable before ctrl finalize
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Router] get_role:
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Vary] role id: failed, guest
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Router] get_role:
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Vary] no custimzed vary
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Ctrl] ? forced no cache [reason] DONOTCACHEPAGE const
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] ?? X-LiteSpeed-Cache-Control: no-cache
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Router] get_role:
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Vary] role id: failed, guest
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Router] get_role:
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Core] CHK html bypass: miss footer const
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Core] run hook litespeed_buffer_finalize
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] [Core] Silence Comment due to REST/AJAX
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] Response headers --- array (
0 => 'Access-Control-Allow-Origin: https://staging.4x4tyres.co.uk',
1 => 'Access-Control-Allow-Credentials: true',
2 => 'Content-Type: text/html; charset=UTF-8',
3 => 'X-Robots-Tag: noindex',
4 => 'X-Content-Type-Options: nosniff',
5 => 'Expires: Wed, 11 Jan 1984 05:00:00 GMT',
6 => 'Cache-Control: no-cache, must-revalidate, max-age=0',
7 => 'Referrer-Policy: strict-origin-when-cross-origin',
8 => 'X-Frame-Options: SAMEORIGIN',
9 => 'X-LiteSpeed-Cache-Control: no-cache',
)
09/14/23 15:39:49.428 [213.246.156.82:56053 1 6rk] End response
--------------------------------------------------Duration: 292.80 ms------------------------------Not sure if that’s any use? I can set you up with Admin access as this is on our staging site if that would help?
@hailite yes the 2nd log above is for normal execution when the ESI block is working as expected.
The first log is when I changed the code from
<esito<xesiin order to break it, so in that case when I purge Litespeed cache and visit the link directly, I don’t see the html input field, I just see this:
And in the HTML:
<div class="fbf-form-group sc-fbf-reg-tyre-search__form--row"> <xesi:include src="/?lsesi=esi_postcode_form_block&_control=private%2Cno-vary&esi=eyJpZCI6InNjLWZiZi1yZWctdHlyZS1zZWFyY2gtLXNpemUtcG9zdGNvZGVfIiwidHlwZSI6InNpemUiLCJjbGFzc2VzIjoic2MtZmJmLXJlZy10eXJlLXNlYXJjaF9fZm9ybS1maWVsZCJ9&_hash=4a42890678f96addcbbb029192abaeca" cache-control="private,no-vary"> <label for="sc-fbf-reg-tyre-search--size-postcode_" class="control-label"> <span class="floating-label">Postcode</span> </label></xesi:include></div>As I say, I’m happy to give you Admin access to our staging site if you want me to?
Thanks for helping!
@hailite yeah I see what you’re saying, but I don’t know.
Here is my code in
filters.php:function esi_postcode_form_block_esi_load($params) { //do_action( 'litespeed_control_set_ttl', 300 ); do_action( 'litespeed_control_set_nocache' ); echo sprintf('<input id="%s" type="text" class="%s %s postcode" data-search_postcode="%s" disabled />', $params['id'], $params['classes'], $params['type']==='size'?'tyre-size':'reg', WC()->session->get('search_postcode')); } add_action( 'litespeed_esi_load-esi_postcode_form_block', '\App\esi_postcode_form_block_esi_load' );So I’m only putting the
<input />into the ESI.And when I output the ESI in my shortcode I am doing this:
if(is_plugin_active('litespeed-cache/litespeed-cache.php')){ $size_postcode_field = apply_filters('litespeed_esi_url', 'esi_postcode_form_block', 'Postcode form block', ['id' => sprintf('sc-fbf-reg-tyre-search--%s-postcode_%s', 'size', $id), 'type' => 'size', 'classes' => 'sc-fbf-reg-tyre-search__form-field']); }else{ $size_postcode_field = sprintf('<input id="sc-fbf-reg-tyre-search--%s-postcode_%s" type="text" class="sc-fbf-reg-tyre-search__form-field %s postcode" data-search_postcode="%s" disabled />', 'size', $id, 'tyre-size', WC()->session->get('search_postcode')); } $html = <<<HTML <div class="fbf-form-group sc-fbf-reg-tyre-search__form--row"> {$size_postcode_field} <label for="sc-fbf-reg-tyre-search--size-postcode_{$id}" class="control-label"> <span class="floating-label">Postcode</span> </label> </div> HTML; return $html;As you can see, I’m not adding the
<label>into the ESI at all, so I don’t know why it’s getting included in the ‘broken’ xesi markup at all.
- The topic ‘Bug with ESI block’ is closed to new replies.
