Reactivation of plugin clears settings

  • Resolved noplanman

    (@noplanman)


    1 year, 10 months ago

    When deactivating and then reactivating the plugin, all settings get set to default.

    The conditionals in the activation method need to be fixed, since the rcno_settings_version key is never set, so the defaults always get set and override any previous setings.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Kemory Grubb

    (@w33zy)

    Hey @noplanman
    I simplified that method to just check if I have a previous settings array and add the default setting if not. Like so:

    $prev_version = get_option( 'rcno_reviews_settings' );
...
...
if ( ! $prev_version ) {
  update_option( 'rcno_reviews_settings', $default_options );
}

    Thanks for catching this.

    Thread Starter noplanman

    (@noplanman)

    Sounds good!

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Reactivation of plugin clears settings’ is closed to new replies.