v5.9.0 introduces severe bugs

@cantoute Anything in the PHP error log? I’ve tested the release with the free version of ACF 6.0.6, but a quick check with 6.0.7 in my test environment didn’t show any issues. Do the errors go away when you go back to 5.8.x? There should probably be some information under Site Health.

In my case, investigating this would imply to clone the site and dig in code made by some pigs.
If it could give some clues, possible that some of the ACF fields are declared as numbers and contain text…
Perhaps you want to wrap anything dealing with ACF in a try catch?

reactivated the wp-Typography just to catch error log

not sure it’s valuable data for you…
so sorry I can’t help, debuging wodpress … I became allergic

I really admire those who has the patience for it (I am TS dev)

Thanks so much for your work

[Sun Jan 22 19:53:19.605278 2023] [proxy_fcgi:error] [pid 28623:tid 140695142561536] [client 185.222.240.66:0] AH01071: Got error ‘PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to Events::__construct() must be of the type int, string given, called in /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fights.php on line 220 and defined in /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Events.php:22\nStack trace:\n#0 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fights.php(220): Events->__construct()\n#1 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fights.php(38): Fights->getEvent()\n#2 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fighters.php(207): Fights->__construct()\n#3 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fighters.php(61): Fighters->calculateNulls()\n#4 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/parts/post-single.php(921): Fighters->__construct()\n#5 /home/bmag/boxemag.com/www.prod/wp-includes/template.php(772): re…’, referer: https://boxemag.com/
[Sun Jan 22 19:53:20.633753 2023] [proxy_fcgi:error] [pid 28545:tid 140695260059392] [client 66.249.64.190:0] AH01071: Got error ‘PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to Events::__construct() must be of the type int, string given, called in /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fights.php on line 220 and defined in /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Events.php:22\nStack trace:\n#0 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fights.php(220): Events->__construct()\n#1 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fights.php(38): Fights->getEvent()\n#2 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fighters.php(207): Fights->__construct()\n#3 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/includes/Fighters.php(61): Fighters->calculateNulls()\n#4 /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/single-palmares.php(4): Fighters->__construct()\n#5 /home/bmag/boxemag.com/www.prod/wp-includes/template-loader.php(106):…’
[Sun Jan 22 19:53:27.254245 2023] [proxy_fcgi:error] [pid 28622:tid 140695268452096] [client 2a01:e0a:2b1:d4c0:f943:1463:bcd0:26e2:0] AH01071: Got error ‘PHP message: PHP Warning: A non-numeric value encountered in /home/bmag/boxemag.com/www.prod/wp-content/themes/zox-news-child/parts/single-fighter/stats.php on line 42’, referer: https://www.google.com/

• This reply was modified 1 year, 10 months ago by cantoute.

You don’t log PHP errors to a file (or logserver)? The stacktrace would be relevant for me. There’s no try ... catch, but everything should be type checked. Anything but an array is cast to a string before processing, so it might output garbage, but it should not result not blow up the site with a 50x.

But anyway, a stack trace or file/line number in wp-Typography would help a lot here. Would you maybe be able to install a modified version (either of a single file or the whole plugin) to check out a fix?

@cantoute Thanks. So it probably is that (string). Sorry. I’ll have a version ready in a few minutes.

Hi @cantoute, I’ve uploaded version 5.9.1-beta.1 to the repository, which should fix the issue. Could you please try it out? You can download the beta from the repository and upload it via your site’s dashboard.

@pepe thank you so much for your quick reactivity.

I’ve tried out 5.9.1-beta.1 and it seams you have nailed my issue.

Very well done.
Thank you <3

Thanks for the quick feedback. I’ve release 5.9.1.

So I just discovered the new menu in ACF where we can individually select how wp-Typography deals with text fields.

I noticed it would default as “Treat as Title”
This could be dangerous on complex setups.

Just a thought, perhaps default to ‘no filter’ would be safer and for backwards compatibility (and saving me manually selecting every field to be ‘no filter’)

Title filtering is pretty gentle, but yeah, maybe feed title would be the better default. But it has been like this ever since ACF 5 support has been introduced (2018 I believe?).

looks like I need an update LOL