Display options should not set other sizes other than it’s own.

  • Resolved waldirb

    (@waldirb)


    2 years, 1 month ago

    Bootstrap has display classes in place in order to hide things in a responsive manner, an example shown here allows you to hide on small screens but show it on large screen. 

    <div class="d-none d-lg-block">hide on screens smaller than lg</div>

    The plugin takes this functionality and it builds it into it’s “Display” tab on each block, however, I feel like the simplify of bootstrap gets lost on the way it’s implemented here, for example if I wanted to have the same functionality as above I would have to select all of the breakpoints up to lg and hide them, something that would end up with a code that looks like the following: 

    <div class="d-none d-sm-none d-md-none d-lg-block">hide on screens smaller than lg</div>

    I know it’s a petty complain but I feel like a simple toggle for “Display on LG” would create cleaner code.

    Overall I am loving developing themes with this plugin and I am very happy with it ??

    • This topic was modified 2 years, 1 month ago by waldirb.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Miles

    (@areoimiles)

    Hi @waldirb

    I completely see your point on this. I think changing this to ‘Display on LG’ would end up with the same problem just reversed.

    For example if you checked the option ‘Display on LG’ then it would be hidden on XS, SM and MD then would display on LG, XL and XXL. But, what if you wanted it to display on LG then be hidden on XL or XXL. By changing how this works, this wouldn’t be possible. You would then need two options. ‘Display on LG’ so it would be hidden up to LG then displayed and then you’d need another option for ‘Hide on XL’ so that it would be hidden on XL. Hopefully that makes sense.

    I think the current implementation, although not as user friendly is the best solution to provide the most flexibility with hiding / displaying blocks however you want across devices.

    If you have a solution that would resolve the above then please let me know as I’m open to changing it, we just need to make sure it provides the same flexibility and continues to work for all use cases.

    Thanks
    Miles

    Plugin Author Miles

    (@areoimiles)

    Hi @waldirb

    I haven’t heard from you in a while so I’m going to close this support ticket. However, if you wish to pick this conversation back up please feel free to get back in touch.

    Thanks
    Miles

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Display options should not set other sizes other than it’s own.’ is closed to new replies.