Works as intended

  • The plugin works as intended, and as of the latest version (1.5.2) it also works with weForms. I’ve left my old review below in case anyone encounters the same problem, but this problem has no longer occurred on the latest version, so everything is working as intended.

    The author was very responsive in dealing with my concerns (as you can see from our exchange below), and even took the extra step to add support for weForms. A well-deserved 5 stars.

    ————————————————–

    The text below is my old review (before 1.5.2) and is left up only in case anyone else encounters the issue. The plugins, today, works as intended.

    Right after installation, this plugin caused WordPress to generate an infinite 302 redirect loop for any logged-in user trying to access the admin dashboard.

    The front-end worked fine. None of the admin pages were accessible.

    The infinite redirect loop caused the page to never load, making the browser show an error because it realizes it’s never going to end.

    Removing the files of this plugin via FTP or other external method fixed the problem.

    It may be due to an incompatibility with another plugin (most plugins installed are well-known ones like WooCommerce, LifterLMS, WP Fastest Cache, Rank Math SEO, Redis Object Cache). Either way, it shouldn’t be doing this.

    Adapting the following code in the file shortcodes-finder/admin/class-shortcodes-finder-admin.php:

    if ( is_admin() && get_option( 'activated_plugin' ) == SHORTCODES_FINDER_PLUGIN_SLUG ) {
	delete_option( 'activated_plugin' );
	exit( wp_redirect( admin_url( 'tools.php?page='. SHORTCODES_FINDER_PLUGIN_SLUG ) ) );
}

    to:

    if ( is_admin() && get_option( 'activated_plugin' ) == SHORTCODES_FINDER_PLUGIN_SLUG ) {
	delete_option( 'activated_plugin' );
	//exit( wp_redirect( admin_url( 'tools.php?page='. SHORTCODES_FINDER_PLUGIN_SLUG ) ) );
}

    which disables the redirect, also fixed the problem.

    After enabling, a second concern shows up: Although it recognizes some shortcodes (like LifterLMS and WooCommerce), it does not suggest the shortcode for weForms. “Find by Content” does find the used weForms shortcodes, but also lists all other shortcodes on all pages.

    Two stars since applying my manual edit makes the plugin run, and although it doesn’t recognize weForms shortcodes it does help to eventually get there (with false positives) via “Find by Content”.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Scribit

    (@scribit)

    Hi @sebastienvercammen. I’m sorry for what happened on your site.

    However, considering it is probably, as you say, an incompatibility with your system (it is the first time I heard abous this problem) it is better to write it as a support topic and not a 1-star review…so I would be happy to correct it and release with a new plugin version.

    For your second issue I will investigate on weForm plugin.
    I think it declare shortcodes in some “custom” way, not standard, that is not recognized by Shortcodes Finder. Not really my fault.

    Thread Starter sebastienvercammen

    (@sebastienvercammen)

    Hey @scribit – a review is a personal opinion about an experience. I think it’s reasonable to give it 1 star when just installing it can cause the admin dashboard to no longer work at all. I’m lucky to be technical enough to get involved, but others might not be, so that’s why I find a 1-star review reasonable. Reviews are something they see before installing, support tickets in progress are not.

    Now, what I’ve done since then to try to help you out:

    1. var_dump of the delete_option to make sure it was succeeding. It was, no problem found.
    2. Installed a brand new website w/ a clean WordPress from scratch + installed all the same versions (all latest) of the exact same plugins, including caching layers and Let’s Encrypt SSL certificate. The tried installing Shortcodes Finder. The problem did not reoccur.
    3. Then I went back to the original website on which the problem occurred to reinstall Shortcodes Finder and see the error in action again.

    And here’s the thing…

    The problem went away.

    The original website can now install and use Shortcodes Finder without any issue at all. Reinstalling does not make the problem go away.

    For reference, I’m the hoster, so I can guarantee there have been no changes whatsoever except my manual debugging tests.

    I did some more digging:

    1. WordPress source code of add_option shows that they call wp_cache_set on line 675 here. This is the mechanism that adds the option.
    2. wp_cache_set source code calls the global object cache.
    3. Remember my original post: I’m using Redis Object Cache. So I dove into that source code.
    4. Which brings us to a custom set() for the global cache instance. Followed by a set() on the redis instance. Which is using PhpRedis, in which we can find a reference to set() in the PHP stub that’s implemented in set() in the C code. This maps to Redis’ (the actual cache engine) SET operation.

    At this point, the documentation mentions that a key can only exist once, so that’s validated.

    Then I did the reverse, for WordPress’ delete_option:

    1. Calls wp_cache_delete
    2. Calls $wp_object_cache->delete
    3. Calls Redis Object Cache’s delete
    4. Calls PhpRedis’ del
    5. Calls Redis’ DEL operation, which we can find in the Redis docs here

    And all of it seems straightforward. I didn’t find anything suspicious at first sight.

    So I’ve updated my review to 4 stars. I couldn’t find the source of the problem, but that doesn’t mean it didn’t (or won’t) happen – and it’s still unfortunate that it doesn’t recognize the weForms shortcodes. If those things were solved, it would get 5 stars.

    Plugin Author Scribit

    (@scribit)

    Hello @sebastienvercammen and thanks for your thorough digging and for the 4 stars.

    I am happy that the plugin now works well but obviously I will always be left wondering what happened on your environment. Please let me know if anything else suspicious happens to your website so we can do more debug.

    For weForms i will inspect on it and I will give you a feedback. I hope soon.

    Plugin Author Scribit

    (@scribit)

    @sebastienvercammen please try the new 1.5.2 versione for weForms compatibility.

    Thread Starter sebastienvercammen

    (@sebastienvercammen)

    @scribit weForms shortcodes now work. I’ve updated my review (see score + text at the top). Thanks for being responsive.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Works as intended’ is closed to new replies.