Settings broken, popup not showing

Hi @nigelgutzmann,

Popup Maker’s select2 is modified and registered differently (pumselect2) globally so that another copy of select2 can be loaded alongside it without issue.

Our main website also uses ACF and we’re not seeing any problems. It’s highly likely another plugin might be causing the error.

Can you try and deactivate other plugins other than ACF and Popup Maker to check this?

Let us know how it goes.

Hi @kimmyx , I tried disabling other plugins and no other plugin resolved the issue. I then disabled ACF Pro, and found that the problem was resolved. So I can confirm that the conflict is indeed with ACF Pro.

Like I said, I need to use ACF Pro. Is there a workaround that you could offer?

Hi @nigelgutzmann,

Thanks for the response.

Have you reached out to ACF Pro about this matter? Since the problem looks to be on their end.

The problem is clearly not on their end. It’s an error happening within the Popup Maker dashboard, which other users have reported with other plugins beyond just ACF (my links above). If we cannot expect a fix from Popup Maker, that’s fine – just let me know, and I will find an alternative.

Hi @nigelgutzmann,

We understand your frustration.

The links you posted above were from 2016 and 12 months ago, and in both cases were resolved.

As explained in my previous post, Popup Maker’s select2 is heavily modified (means the plugin has its own select2), so it shouldn’t cause any problems regarding that matter.

Since we cannot replicate this issue (we use ACF Pro in our main plugin site, but do not encounter this), and hasn’t been reported by anyone else, we’re not quite sure what workaround we can offer at this point.

We ask for your understanding.

@nigelgutzmann – I think you’ve proven our case in your opening message, these conflicts are not coming from our code directly.

Why does Popup Maker not supply its own version of select2, which will definitely work, rather than relying on other plugins to supply select2, which could be any version (and thus potentially incompatible with Popup Maker)?

You linked to “related issues”, and the one from 2016 goes over the issue, and the very first response covers that we already rewrote it exactly as your quote above suggests, 7 years ago..

https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/admin/general/vendor/select2.full.custom.js

I wrote it this way for exactly the reason your saying is now our fault, to avoid any possible conflicts. The only way our pumselect2 interferes with ACF Pro is if they also rewrote select2 and happened to use the exact same name pumselect2. Highly unlikely.

And 700k installs later, we don’t see mass reports of issues, which we would as a decent portion of our user base also uses ACF

Also nearly all of our sites use ACF Pro & many of our extensions without issues in Popup interfaces or ACF interfaces.

Some follow ups though to try and narrow things down a bit further.
1. Do you have ACF custom fields for popups?
2. Have you considered a 3rd plugin that only does something when ACF is active, thus disabling ACF does make it go away leading to the assumption ACF or PM is the cause.

• This reply was modified 2 years ago by Daniel Iser.

Just to be sure, tested on clean install just now, couple screenshots. No issues editing popups, and you can see clearly that their copy of Select2 is loaded.

https://share.wppopupmaker.com/YEuDNxoN
https://share.wppopupmaker.com/z8ulpzZ8

@nigelgutzmann – Ok so I did some more digging & looked at a few older reports in our email & facebook that weren’t quite the same but showed strangeness.

Found that we had a fallback in case pumselect2 wasn’t found for some reason. It appears that in some edge cases (3+ copies of Select2 loaded) the timing of script loads could have somehow triggered it to fallback even if ours was loaded.

In the case I was able to test (Popup Maker + WP Fusion + ACF Pro fields on popup) I did notice some CSS changes where the fields were being set up using the wrong CSS classes (missing pum prefix).

I couldn’t work out how that was happening as the on change functionality was using our version of pumselect2, but the css classes appeneded to elements clearly came from the others.

I have removed that fallback as it shouldn’t ever be necessary and would indicate our code wasn’t loading correctly anyways.

That MIGHT resolve your issue, though I’m not really certain as it was hard enough to narrow down as it was. The only thing it changed for my tests was that the dropdowns appeared farther down the page than they should. They were still there but not positioned correctly due to class mismatches.

Hope that is helpful in the end result. If not would need more access to debug directly on your end.

Yes, after updating Popup Maker the issue was resolved! Thank you so much!