Ships a large number of development dependencies

  • Resolved David Anderson

    (@davidanderson)


    2 years, 2 months ago

    I was looking at this plugin to evaluate using it. You’re shipping a large number of unused developer dependencies in vendor/, each with the potential to clash with other plugins having incompatible versions. It’s best not to shop development dependencies in the released version. When running composer, the release version’s dependencies should be generated by using the --no-dev flag on the composer command line.

    David

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Sanjeev Aryal

    (@sanzeeb3)

    Hi David,

    Thanks for the reaching out. It’s a known issue https://github.com/sanzeeb3/wp-frontend-delete-account/issues/60

    will be fixed on next release.

    each with the potential to clash with other plugins having incompatible versions

    The deps aren’t loaded for the potential clash.

    Have a good day ??

    Thread Starter David Anderson

    (@davidanderson)

    > The deps aren’t loaded for the potential clash.

    But they are – you’re calling require 'vendor/autoload.php' unconditionally whenever the plugin loads, and then composer is then loading all those classes into the namespace. Any other plugin trying to use a class is going to get your version because of that. (In WordPress, it’s best to only call your autoloader at the point that you actually need one, to avoid this issue). Just because your code doesn’t use those classes doesn’t prevent the autoloader bringing them all in.

    David

    Plugin Author Sanjeev Aryal

    (@sanzeeb3)

    Hi David,

    Thanks for sharing the details of the issue. I’ll fix this Asap.

    Good day ??

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Ships a large number of development dependencies’ is closed to new replies.