Slow TEC events updates with Yoast Duplicate Post

  • Resolved therealgilles

    (@chamois_blanc)


    2 years, 6 months ago

    I use the Events Calendar [TEC] (Pro) on one of my sites. I’ve noticed that for a few months now, updating TEC events is super slow in the admin interface, especially for recurring events. The update takes 30+ seconds, sometimes even more than a minute, which becomes unusable.

    If I disable the Yoast Duplicate Post plugin, the performance becomes much better, usually fewer than 10 seconds (which is not great but way better and usable).

    XDebug points to the following functions:

    Yoast\WP\Duplicate_Post\UI\Classic_Editor->change_republish_strings_classic_editor <cycle 4>
    Yoast\WP\Duplicate_Post\UI\Classic_Editor->should_change_rewrite_republish_copy <cycle 4>
    Yoast\WP\Duplicate_Post\Permissions_Helper->is_rewrite_and_republish_copy <cycle 4>
    Yoast\WP\Duplicate_Post\UI\Classic_Editor->change_schedule_strings_classic_editor <cycle 4>

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter therealgilles

    (@chamois_blanc)

    This code may be related to the problem:

    
		\add_filter( 'gettext', [ $this, 'change_republish_strings_classic_editor' ], 10, 2 );
		\add_filter( 'gettext_with_context', [ $this, 'change_schedule_strings_classic_editor' ], 10, 3 );

    You should not be running get_post() in a gettext* filter! This is surely going to tank the site performance. gettext* are meant for text translations only. The filter functions have to be super simple and fast.

    Plugin Support Michael Ti?a

    (@mikes41720)

    Hi @chamois_blanc

    Thanks for informing us about this issue. Just to clarify, could you check if you are running the latest version of Yoast Duplicate Post v4.4, as well as the latest version of all your other plugins and themes?

    Often, we see problems occur in combination with another plugin or theme. The fastest way to rule out any conflict, is to deactivate all non-Yoast plugins and switch to a standard theme like Twenty Twenty.

    Please test this on your development or staging site, if you have one. If not, we recommend using the Health Check & Troubleshooting plugin. This plugin has a troubleshooting mode, which does not affect normal visitors to your site.

    If you’re unfamiliar with checking for conflicts, we’d like to point you to a step-by-step guide that will walk you through the process: How to check for plugin conflicts

    Are you still able to reproduce the issue even with a default WP theme and only Yoast Duplicate Post and The Events Calendar as the plugins enabled? If so, please do create a bug report for the GitHub repository here. Thank you!

    Thread Starter therealgilles

    (@chamois_blanc)

    Hey Michael,

    Thank you for your response but please talk to the plugin developer asap. This has nothing to do with a plugin conflict, it’s related to how the plugin code is written.

    The same issue has already been posted on GitHub on June 6th, 2021:
    https://github.com/Yoast/duplicate-post/issues/185

    yet nothing has been done. This is unfortunate as it is a great plugin otherwise. Please help us get it fixed.

    Plugin Support Michael Ti?a

    (@mikes41720)

    Hi @chamois_blanc

    We’ll let our development team know about this concern. Thanks for reporting this.

    Thread Starter therealgilles

    (@chamois_blanc)

    Hey @mikes41720, it’s been a week since I reported this major usability and performance issue. I really like the plugin and would like to continue using it, but I can’t if it slows down my site x30. I hope to hear about a fix soon.

    Plugin Support Jeroen Rotty

    (@jeroenrotty)

    Hey @chamois_blanc,

    Just earlier we released version 4.5, which should include an improvement. Can you please update and have a look if the performance is better? Thank you!

    Thread Starter therealgilles

    (@chamois_blanc)

    Hi @jeroenrotty, I had a chance to test the new version out yesterday and performance looks WAY better. Thank you so much for being willing to hear me out and taking actions, that will hopefully make your plugin better and improve performances for its users.

    It would be great if you could point me to a changelog or write-up on how you went about fixing or improving the issue.

    Plugin Support Jeroen Rotty

    (@jeroenrotty)

    Hey @chamois_blanc,

    Thank you for letting us know the performance is way better, happy to hear that.

    On the technical details, you might want to look at the PR that our developers made to combat the performance: https://github.com/Yoast/duplicate-post/pull/255.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Slow TEC events updates with Yoast Duplicate Post’ is closed to new replies.