“hd-timeline.less” is always loaded

  • Resolved fahmifitu

    (@fahmifitu)


    2 years, 7 months ago

    Hello..

    in elements/bootstrap.php

    this line: is_null($config->get('~theme.hd.elements')) always return true, causing hd-timeline.less to always get loaded even when it’s toggled off. is there reason for this check, shouldn’t $config->get('~theme.hd.elements.hd-timeline') this check be sufficient?

    Thanks in advance.

    • This topic was modified 2 years, 7 months ago by fahmifitu.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author forrestkirby

    (@forrestkirby)

    Hi fahmifitu,

    is_null($config->get('~theme.hd.elements')) is required if a user has not yet saved the settings for Herzog Dupont within YOOtheme Pro. In this case, ~theme.hd.elements will be null but the LESS files should still be loaded, e. g. if the plugin has been initially installed.

    However, as you correctly noticed $config->get('~theme.hd.elements') always returns null in the theme function. This is wrong and I will take a look at the issue. Thanks for reporting!

    Kind regards

    Plugin Author forrestkirby

    (@forrestkirby)

    Hi fahmifitu,

    unfortunately, ~theme is empty at the moment when 'theme' => function (Config $config) {} is being executed (confirmed by YOOtheme). Therefore, I will remove the check for the element status in the next version. Once there is a way to properly perform this check, I might eventually add it again.

    Kind regards

    Thread Starter fahmifitu

    (@fahmifitu)

    Thanks for your response. I noticed this issue when using WP Hide to change the directory name, it broke the whole builder when the plugin is trying to import the stylesheet.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘“hd-timeline.less” is always loaded’ is closed to new replies.