• Resolved alexanderbinder

    (@alexanderbinder)


    I have checked the plugin with phpstan under php8.0.17, WP 5.9.2 and ubuntu 20.04

    following incompatibilities were reported

    —— ——————————————————————————————————–
    Line web/wp-content/plugins/sales-manago/src/Admin/Controller/SettingsController.php
    —— ——————————————————————————————————–
    12 Class bhr\admin\View\SettingsRenderer referenced with incorrect case: bhr\Admin\View\SettingsRenderer.
    41 Class bhr\admin\View\SettingsRenderer referenced with incorrect case: bhr\Admin\View\SettingsRenderer.
    —— ——————————————————————————————————–
    —— ———————————————————————————–
    Line web/wp-content/plugins/sales-manago/src/Admin/Entity/MessageEntity.php
    —— ———————————————————————————–
    33 Unsafe usage of new static().
    See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
    —— ———————————————————————————–
    —— ————————————————————————————————————————————————-
    Line web/wp-content/plugins/sales-manago/src/Admin/Entity/PlatformSettings.php
    —— ————————————————————————————————————————————————-
    59 Unsafe usage of new static().
    See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
    172 Method bhr\Admin\Entity\PlatformSettings::setPluginFf() should return $this(bhr\Admin\Entity\PlatformSettings) but return statement is missing.
    —— ————————————————————————————————————————————————-
    —— ————————————————————————————————————-
    Line web/wp-content/plugins/sales-manago/src/Frontend/Model/CookieManager.php
    —— ————————————————————————————————————-
    19 Method bhr\Frontend\Model\CookieManager::setCookie() should return bool but return statement is missing.
    42 Method bhr\Frontend\Model\CookieManager::deleteCookie() should return bool but return statement is missing.
    —— ———————————————————————
    —— ————————————————————————————————–
    Line web/wp-content/plugins/sales-manago/vendor/salesmanago/api-sso-util/src/Entity/Configuration.php
    —— ————————————————————————————————–
    192 Unsafe usage of new static().
    See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
    —— ————————————————————————————————–
    —— ——————————————————————————————————————
    Line web/wp-content/plugins/sales-manago/vendor/salesmanago/api-sso-util/src/Factories/ReportFactory.php
    —— ——————————————————————————————————————
    22 Method SALESmanago\Factories\ReportFactory::doHealthReport() should return bool but return statement is missing.
    43 Method SALESmanago\Factories\ReportFactory::doUsageReport() should return bool but return statement is missing.
    65 Method SALESmanago\Factories\ReportFactory::doDebugReport() should return bool but return statement is missing.
    —— ——————————————————————————————————————
    —— ———————————————————————————————————————-
    Line web/wp-content/plugins/sales-manago/vendor/salesmanago/api-sso-util/src/Model/Collections/AbstractCollection.php
    —— ———————————————————————————————————————-
    101 Method SALESmanago\Model\Collections\AbstractCollection::valid() should return bool but return statement is missing.
    —— ———————————————————————————————————————-

    could you please fix that issues

Viewing 3 replies - 1 through 3 (of 3 total)
  • Hello Alexander!
    You are very brave.

    Plugin Author SALESmanago

    (@salesmanag0)

    Hi Alexander,

    thank you for your feedback. We will fix all incomatibilities with PHP 8 in the next release. However, we still have to maintain compatibility with PHP 5.6 as required by the WordPress Marketplace.

    Best regards,
    Sergiusz Olszewski

    Plugin Author SALESmanago

    (@salesmanag0)

    Hello Alexander,

    Thank you for the patiance. Today we have released a new version of SALESmanago plugin with PHP8 compatibility in mind.

    We have also started to test our plugin with WordPress 6.0, and if there are any changes necessary, we will update the plugin before WordPress 6.0 goes public.

    I hope this helps you.

    Best regards,
    Sergiusz Olszewski

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘php8 incompatibilities and warnings’ is closed to new replies.