SiteOrigin Icon Font Size Bug

  • Resolved The Web Orchard

    (@theweborchard)


    3 years, 6 months ago

    The SiteOrigin Icon plugin font size ‘measurement’ field defines two inputs, size and size_unit.

    size_unit is missing from the less variables (and, by extention, the less file itself), and so the compiled CSS just contains the number and is discarded as invalid by the browser.

    Changing so-widgets-bundle/widgets/icon/icon.php:82 to include $instance[‘size_unit’] (e.g. 'size' => $instance['size'].$instance['size_unit'],) appears to resolve this.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor alexgso

    (@alexgso)

    Hi,

    Thank you for the report. The unit is automatically appended to measurement fields when added as a LESS variable. I’ve run a few tests with the icons widget and I’m having trouble replicating this result. Are you able to replicate this issue with a new instance of the widget? If so, can you please send me an export of a layout that contains a widget where this issue is occurring?

    To export a page, open up a page in the editor and click the Layout button in the Page Builder toolbar. Click Import/export and then click download. Please upload the export to a 3rd party file hosting site such as WeTransfer (no email is required).

    Kind regards,
    Alex

    Thread Starter The Web Orchard

    (@theweborchard)

    I’ve tested it with a brand new layout, with just the one widget (the icon widget – I picked a different icon, from a different icon set), same result.

    Layout export (was small enough I figured WeTransfer wasn’t needed):

    {"widgets":[{"icon":"genericons-404","color":"","size":"2","size_unit":"rem","alignment":"center","url":"","title":"","_sow_form_id":"140088395260a4f2f0a2513812301485","_sow_form_timestamp":"1621422851023","ids":"","classes":"","panels_info":{"class":"SiteOrigin_Widget_Icon_Widget","raw":true,"grid":0,"cell":0,"id":0,"widget_id":"4550b3e9-ffa4-4529-bdb8-934e5664eb5e","style":{"id":"","class":"","widget_css":"","mobile_css":"","margin":"","padding":"","mobile_padding":"","background":"","background_image_attachment":"0","background_image_attachment_fallback":"","background_display":"tile","border_color":"","font_color":"","link_color":""}}}],"grids":[{"cells":1,"style":{}}],"grid_cells":[{"grid":0,"index":0,"weight":1,"style":{}}],"name":"Icon Test"}

    Plugin Contributor alexgso

    (@alexgso)

    Hi,

    Thanks, I’ve tried the provided layout and it’s working as expected for me.
    Can you please link me to a page a website of yours where I can inspect an icon where this issue is happening?

    Also, are you using the latest version of SiteOrigin Widgets Bundle? You can find what version you’re using by navigating to Installed Plugins > Installed and scroll down to SiteOrigin Widgets Bundle. The version is listed below the plugin description. I ask as there is an older version of SiteOrigin Widgets Bundle where the unit of measurement isn’t saved correctly so if you’re using an older version that may explain the issue you’re facing.

    Kind regards,
    Alex

    Plugin Support Andrew Misplon

    (@misplon)

    Hi The Web Orchard

    Thanks for reaching out. A quick follow-up to check to see if you’ve made progress. If not, please, check out the questions above from Alex, we’ll assist from there.

    Cheers ??

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘SiteOrigin Icon Font Size Bug’ is closed to new replies.