3.1.5 breaks with wp-stateless
-
Prior to this release (3.1.5) things were ok. Now we get errors like:
chmod($filename = 'gs://MYBUCKET/www/fvm-cache/min/jsd568b41b64424676XXX2fb1361b86ed51ae6b009e56688417c07015774c3.js'wordpress 5.7.1 w/ wp-stateless 3.1.1 on php 8 on ubuntu 20.04
i do not have any ‘cdn options’ enabled.
This was working previously.
I think the desired behaviour is to not store the cache back to the stateless store (since it will rebuild locally as needed).[25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP Warning: Trying to access array offset on value of type null in /app/wp-content/plugins/fast-velocity-minify/inc/admin.php on line 30" [25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP Stack trace:" [25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP 1. {main}() /app/wp-admin/plugins.php:0" [25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP 2. require_once() /app/wp-admin/plugins.php:10" [25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP 3. do_action($tag = 'admin_init') /app/wp-admin/admin.php:175" [25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP 4. WP_Hook->do_action($args = [0 => '']) /app/wp-includes/plugin.php:484" [25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP 5. WP_Hook->apply_filters($value = '', $args = [0 => '']) /app/wp-includes/class-wp-hook.php:316" [25-Apr-2021 21:04:09] WARNING: [pool www] child 76 said into stderr: "NOTICE: PHP message: PHP 6. fvm_check_minimum_requirements('') /app/wp-includes/class-wp-hook.php:292" {"time": "2021-04-25T21:04:09+00:00","downstream_remote_address": "172.17.0.1","x_forward_for": "172.17.0.1","request_id": "","remote_user": "","bytes_sent": 3914,"start_time": 0.001,"response_code": 200,"authority": "localhost","protocol": "HTTP/1.1","path": "/webpushr-sw.js.php","request_query": "","request_length": 1116,"duration": 0.001,"method": "GET","http_referrer": "https://localhost/webpushr-sw.js.php","http_user_agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.19 Safari/537.36","sub": ""} 2021/04/25 21:04:11 [error] 89#89: *27 FastCGI sent in stderr: "PHP message: PHP Warning: Trying to access array offset on value of type null in /app/wp-content/plugins/fast-velocity-minify/inc/admin.php on line 30PHP message: PHP Stack trace:PHP message: PHP 1. {main}() /app/wp-admin/plugins.php:0PHP message: PHP 2. require_once() /app/wp-admin/plugins.php:10PHP message: PHP 3. do_action($tag = 'admin_init') /app/wp-admin/admin.php:175PHP message: PHP 4. WP_Hook->do_action($args = [0 => '']) /app/wp-includes/plugin.php:484PHP message: PHP 5. WP_Hook->apply_filters($value = '', $args = [0 => '']) /app/wp-includes/class-wp-hook.php:316PHP message: PHP 6. fvm_check_minimum_requirements('') /app/wp-includes/class-wp-hook.php:292" while reading response header from upstream, client: 172.17.0.1, server: _, request: "GET /wp-admin/plugins.php HTTP/1.1", upstream: "fastcgi://unix:/run/php/php8.0-fpm.sock:", host: "localhost", referrer: "https://localhost/"The page I need help with: [log in to see the link]
Viewing 13 replies - 1 through 13 (of 13 total)
-
so i see 3.1.6 is there.
wp plugin list |grep fast fast-velocity-minify active none 3.1.6but, it does not work. Note that it has the bucket name (gs://) rather than the filesystem path.
9. is_dir($filename = 'gs://agilicus/www/fvm-cache/min') /app/wp-content/plugins/fast-velocity-minify/inc/common.php:407" Warning: is_dir(): Unable to find the wrapper "gs" - did you forget to enable it when you configured PHP? in /app/wp-content/plugins/fast-velocity-minify/inc/common.php on line 407" Stack trace:" 1. shutdown_action_hook() /app/wp-includes/load.php:0" 2. do_action($tag = 'shutdown') /app/wp-includes/load.php:1072" 3. WP_Hook->do_action($args = [0 => '']) /app/wp-includes/plugin.php:484" 4. WP_Hook->apply_filters($value = '', $args = [0 => '']) /app/wp-includes/class-wp-hook.php:316" 5. wp_ob_end_flush_all('') /app/wp-includes/class-wp-hook.php:292" 6. ob_end_flush() /app/wp-includes/functions.php:4757" 7. fvm_process_page($html = '<!DOCTYPE html>\n<html lang="en-CA" xmlns:og="https://opengraphprotocol.org/schema/" xmlns:fb="https://www.facebook.com/2008/fbml">\n\n<head>\n\t\n\t<meta charset="UTF-8">\n\t<meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n\t<link rel="profile" href="https://gmpg.org/xfn/11">\n\t\t<script>\nvar __wpcal_dist_url = "https://localhost/wp-content/plugins/wpcal/dist/";\n</script>\n\t\t<!-- Manifest added by SuperPWA - Progressive Web Apps Plugin For WordPress -->\n<link rel="ma', 9) /app/wp-includes/functions.php:4757" 8. fvm_generate_min_url($url = 'https://localhost/wp-content/plugins/simply-gallery-block//plugins/pgc_sgb_lightbox.min.js?ver=2.1.0', $tkey = 'js454ac412348acc9383e7ea30e4dda89d7c62146b0787b6035d6027816134ea', $type = 'js', $code = 'try{\n!function(e){var t={};function i(n){if(t[n])return t[n].exports;var s=t[n]={i:n,l:!1,exports:{}};return e[n].call(s.exports,s,s.exports,i),s.l=!0,s.exports}i.m=e,i.c=t,i.d=function(e,t,n){i.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},i.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},i.t=function(e,t){if(1&t&&(e=i(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__') /app/wp-content/plugins/fast-velocity-minify/inc/frontend.php:707" 9. is_dir($filename = 'gs://agilicus/www/fvm-cache/min') /app/wp-content/plugins/fast-velocity-minify/inc/common.php:407" Warning: chmod(): Unable to find the wrapper "gs" - did you forget to enable it when you configured PHP? in /app/wp-admin/includes/class-wp-filesystem-direct.php on line 173" Stack trace:" 1. shutdown_action_hook() /app/wp-includes/load.php:0" 2. do_action($tag = 'shutdown') /app/wp-includes/load.php:1072" 3. WP_Hook->do_action($args = [0 => '']) /app/wp-includes/plugin.php:484" 4. WP_Hook->apply_filters($value = '', $args = [0 => '']) /app/wp-includes/class-wp-hook.php:316" 5. wp_ob_end_flush_all('') /app/wp-includes/class-wp-hook.php:292" 6. ob_end_flush() /app/wp-includes/functions.php:4757" 7. fvm_process_page($html = '<!DOCTYPE html>\n<html lang="en-CA" xmlns:og="https://opengraphprotocol.org/schema/" xmlns:fb="https://www.facebook.com/2008/fbml">\n\n<head>\n\t\n\t<meta charset="UTF-8">\n\t<meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">\n\t<link rel="profile" href="https://gmpg.org/xfn/11">\n\t\t<script>\nvar __wpcal_dist_url = "https://localhost/wp-content/plugins/wpcal/dist/";\n</script>\n\t\t<!-- Manifest added by SuperPWA - Progressive Web Apps Plugin For WordPress -->\n<link rel="ma', 9) /app/wp-includes/functions.php:4757" 8. fvm_generate_min_url($url = 'https://localhost/wp-content/plugins/simply-gallery-block//plugins/pgc_sgb_lightbox.min.js?ver=2.1.0', $tkey = 'js454ac412348acc9383e7ea30e4dda89d7c62146b0787b6035d6027816134ea', $type = 'js', $code = 'try{\n!function(e){var t={};function i(n){if(t[n])return t[n].exports;var s=t[n]={i:n,l:!1,exports:{}};return e[n].call(s.exports,s,s.exports,i),s.l=!0,s.exports}i.m=e,i.c=t,i.d=function(e,t,n){i.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},i.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},i.t=function(e,t){if(1&t&&(e=i(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__') /app/wp-content/plugins/fast-velocity-minify/inc/frontend.php:707" 9. WP_Filesystem_Direct->put_contents($file = 'gs://agilicus/www/fvm-cache/min/js454ac412348acc9383e7ea30e4dda89d7c62146b0787b6035d6027816134ea.js', $contents = 'try{\n!function(e){var t={};function i(n){if(t[n])return t[n].exports;var s=t[n]={i:n,l:!1,exports:{}};return e[n].call(s.exports,s,s.exports,i),s.l=!0,s.exports}i.m=e,i.c=t,i.d=function(e,t,n){i.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},i.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},i.t=function(e,t){if(1&t&&(e=i(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__', $mode = *uninitialized*) /app/wp-content/plugins/fast-velocity-minify/inc/common.php:423" 10. WP_Filesystem_Direct->chmod($file = 'gs://agilicus/www/fvm-cache/min/js454ac412348acc9383e7ea30e4dda89d7c62146b0787b6035d6027816134ea.js', $mode = FALSE, $recursive = *uninitialized*) /app/wp-admin/includes/class-wp-filesystem-direct.php:86" 11. chmod($filename = 'gs://agilicus/www/fvm-cache/min/js454ac412348acc9383e7ea30e4dda89d7c62146b0787b6035d6027816134ea.js', $permissions = 420) /app/wp-admin/includes/class-wp-filesystem-direct.php:173" Warning: Undefined variable $check in /app/wp-content/plugins/fast-velocity-minify/inc/common.php on line 782"But previously, it was also using the filesystem. You needed to have a writeable public directory for FVM to put the generated css and js files.
I understand what wp-stateless does, but the uploads directory should still be there, even if it’s not writeable (if it is, then better of course).
FVM cannot interact with the remote cloud storage because it would be too slow, whenever it needs to “upload” multiple files and your TTFB would suffer. It needs to write the files somewhere.
I have another plugin that has the option to use dynamic css and js files, so there are no disk writes (this is not for sale, only for my clients).
I was thinking I can port that feature down to FVM, however note, you would need to use that feature with a CDN or server side cache. Else the server load would increase significantly with all of the dynamic requests for the css and js files, especially with http2 enabled.
Will it solve the issue for you, if I add an option to overwrite the default uploads directory with a custom file path that can be defined on
wp-config.php?
It should be similar to the old version, you specify a public url and a public directory path. You still need a public directory though… for FVM to write files into it directly.Edit, just noticed you said you have 2 servers. In that case, even the previous version wouldn’t work (it would generate only on one server separately), unless of course, you had a shared mount for them.
For multiserver setups, serving the minified files dynamically would be better.
Viewing 13 replies - 1 through 13 (of 13 total)
- The topic ‘3.1.5 breaks with wp-stateless’ is closed to new replies.
