All in One SEO plugin conflict

  • Gabor

    (@nextendweb_gabor)


    4 years, 1 month ago

    Hi! You seem to have an output buffer conflict with All in One SEO plugin. As far as my colleague managed to track down the issue, it comes from that in this file:
    /wp-content/plugins/themify-builder/themify/class-themify-enqueue.php
    your output buffer starts at line 272 and ends at 569. This file:
    /wp-content/plugins/all-in-one-seo-pack/app/Common/Main/Head.php
    closes it at line 128. This way your CSS files are getting into a wrong place in the HTML code. To reproduce the issue, please follow this guide:

    1. Create a minimal theme:
    \wp-content\themes\test\

    index.php:

    <!DOCTYPE html>
<html>
    <head>
    <?php wp_head(); ?>
    </head>
    <body>
	<?php
		the_content();
		wp_footer();
	?>
    </body>
</html>

    style.css:

    /*
 Theme Name:   test
*/

    2. Activate this theme on your website. Then install All in One SEO and Themify Builder into this site.

    3. Go to the frontend of the website -> right click on it -> choose “View page source”

    Result:
    You will see that your minified CSS files are getting before the <!DOCTYPE html> part, making the html code invalid.

    (For this ticket I’m rather marking on of the supporters of All in One SEO, so they would know about it too: @arnaudbroes)

Viewing 3 replies - 1 through 3 (of 3 total)

  • ??

    So we looked into this today and identified this as an output buffering conflict. AIOSEO uses output buffering as a last resort to rewrite the title if the theme doesn’t support the official method to do this.

    We’re adding a filter in the next version of AIOSEO that you can use to prevent this. Feel free to let me know if you’re still running into this error and I’ll be happy to send you a code snippet for the filter hook once it’s released (4.0.16).

    We don’t fully understand though why Themify Builder injects their inline styles via output buffering since there are hooks you can use for that (I’m thinking of wp_head and wp_print_styles, just to name a few). If they were (able) to do that, that would prevent this conflict from happening in the first place.

    Steve M

    (@wpsmort)

    @nextendweb_gabor We’ve now added a filter today which should resolve this. You can find the filter code here – https://aioseo.com/docs/aioseo_flush_output_buffer/

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘All in One SEO plugin conflict’ is closed to new replies.