woo-advanced-discounts Plugin error

hi @acanessa,

Which version of the plugin do you have?

Hi! It seems that 2.21

hello @acanessa
please what theme are you using?

• This reply was modified 4 years, 1 month ago by maur.

Hi!
https://themeforest.net/item/halena-minimal-modern-ecommerce-wordpress-theme/21142525?gclid=CjwKCAiAl4WABhAJEiwATUnEFyHcWzAH-wQu0r2304CHy7xto-dVVkepTAjmrZgZb73FdqxaKjaO6hoCBlwQAvD_BwE

It′s this one.
I had to disable the plugin, but now i need another way to make it work.

hi,
can you try to activate storefront to see if the error still appears? please

having same issue caused by your plugin on different template.
Is your plugin only compatible with original WooCommerce theme but not with millions of other themes?

• This reply was modified 4 years ago by itoolsolution.

it appears to be a problem in class-wad-discount.php

// public function shortcode_products_query( $args, $attribute, $type ) {
public function shortcode_products_query( $args, $attribute ) {
global $wad_discounts;
$wad_on_sale_products = array();

if( isset( $attribute['ids'] ) && ! empty( $attribute['ids'] ) ) {
return $args;
}

// if( 'sale_products' === $type )
{
foreach ( $wad_discounts['product'] as $discount_obj ) {

$product_list = $discount_obj->products_list->get_products(true);
$discounted_products = wad_filter_on_sale_products( $product_list, $discount_obj );
$wad_on_sale_products = array_merge( $wad_on_sale_products, $discounted_products );
}
}

if( empty( $wad_on_sale_products ) ) {
return $args;
}

$args['post__in'] = array_merge( $args['post__in'], $wad_on_sale_products );

return $args;
}

Hello @itoolsolution @acanessa , what themes are enabled on your websites please and how to reproduce the issue ?
Thank you

Hey! Sorry for the late reply, you can check the error over here: https://grupotrent.com.uy/ at the home page.
And the theme enabled is: https://themeforest.net/item/halena-minimal-modern-ecommerce-wordpress-theme/21142525?gclid=CjwKCAiAl4WABhAJEiwATUnEFyHcWzAH-wQu0r2304CHy7xto-dVVkepTAjmrZgZb73FdqxaKjaO6hoCBlwQAvD_BwE

@donaldlaly
we are using this template
https://themeforest.net/item/funiter-elegant-furniture-shop-for-woocommerce/23005729
I cannot demonstrate the problem any more as we have fixed it on our end, but you need to fix your extension as it’s not backwards compatible and causing issues to the people.

So is there any easy fix?

Could you please contact our tech support on the plugin website so that we can help you to fix it?