Adding breaks after image ends up above instead

  • Resolved thequasar

    (@thequasar)


    4 years, 2 months ago

    For images with credits applied, when adding breaks, instead of the breaks appearing below the image, it instead appears above.

    The behavior is unlike what you’d normally get with e.g. the regular caption.

    Is it possible to address this?

    Screencapture example:
    https://gyazo.com/8e08b2742b257e27eb4e3fb016539d55

    Sidenote:
    Since I didn’t want to modify the plugin itself, I was hoping to bypass this by running a local script in the admin area and change all element <span data-media-credit-text="text"/> to <dd/> when images are inserted, because this gives me the behavior I want (like image captions). However, when saving the post, it actually gets deattached from the [/media-credit] shortcode.

    • This topic was modified 4 years, 2 months ago by thequasar.
    • This topic was modified 4 years, 2 months ago by thequasar.
Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author pepe

    (@pputzer)

    Sorry for the delay. I’ll look into this.

    Thread Starter thequasar

    (@thequasar)

    Thank you in advance!

    Plugin Author pepe

    (@pputzer)

    Hi @thequasar, I’ve added GitHub issue to track this bug.

    Thread Starter thequasar

    (@thequasar)

    Thanks for keeping me updated pepe!

    Since I wanted to resolve the issue as fast as possible on my end, I ended up using a custom solution found here.

    I don’t know if it will help you resolve the issue for your plugin, but I thought I’d leave it as a reference.

    Cheers

    Plugin Author pepe

    (@pputzer)

    Hi @thequasar, can you tell me (or better: show me via another screen capture) the behaviour with a regular caption and without Media Credit enabled? Because on my test site with Twenty Twenty-One, the behaviour is the same (new line inserted before the image).

    When I insert an image without a caption, the newline is inserted after the image.

    • This reply was modified 3 years, 8 months ago by pepe.
    Plugin Author pepe

    (@pputzer)

    OK, after further experimentation, what might have irritated you is that an image with a credit always behaves like an image with a caption, even if there is no actual caption set.

    Thread Starter thequasar

    (@thequasar)

    @pputzer I’m not completely sure of the behaviors you mentioned, but the behavior that I was looking for was to be able to press the “enter”-key and add a new line after/below the image. (I will assume every image has credits added using the Media Credit plugin throughout this post.)

    As you can see in the screencapture, in the first post, it shows that the new line is placed above the image, despite the cursor being placed after (to the right) of the image.

    Thus, it’s not possible to create a new line that is below the image. If your last element is an image, it would mean it’s not possible to add more content below it.

    In this screencapture where I’m using the native caption, you can see when I click the “enter”-key while the cursor is placed after the caption, it adds the new line below the image—and not above.

    Hope gives a little more clarity.

    • This reply was modified 3 years, 8 months ago by thequasar.
    Plugin Author pepe

    (@pputzer)

    Thank you, @thequasar. I’ve identified the issue and implemented a fix for the next version. I’d classify the inconsistent behavior between images with and without captions as a Core bug as well, do you want to file the Trac ticket?

    Thread Starter thequasar

    (@thequasar)

    That’s great to hear!

    Since I’ve already implemented my own solution for my site, I have unfortunately not been actively investigating the issue myself. As such, with your new findings, feel free to go ahead and file the ticket!

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Adding breaks after image ends up above instead’ is closed to new replies.