Activating Maintainn Tools literally doubled my database queries in QM

  • I found your tools plugin via this blog post: https://wefoster.co/the-worst-wordpress-performance-problem-youve-never-heard-of-tppucs

    My DB queries on the plugins.php page literally more than doubled from 280 > 664 when activating your plugin. This seems to only be applicable on the plugins page. I assume this is because you guys are making additional queries on a per-plugin basis to determine whether it’s auto-update functionality is enabled, locked or there is a note. Hoping you can optimize however your plugin functions to reduce the number of DB calls, 2.5xing the number of queries is a bit excessive and negatively impacts performance on the plugins page. Thanks!

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    It likely is in part that, but also the detail that we have the ability to store notes on a per-plugin basis as well, so it’d need to work with that part too.

    I’ll file an issue to see what we can do to help with this, and better optimize.

    Thread Starter jazir5

    (@jazir5)

    I notice that your plugin removes access to update-core.php, and also the plugin updates section in plugins. Where can i access a list of plugins that are updatable and have not had update checks locked, while your plugin is active? Is there a comparable section for plugins that still have checks enabled?

    If not, would it be possible for you to create a tab in plugins that is similar to the default updates tab, but only runs update checks manually once that specific tab is loaded in a browser tab(and only for the remaining plugins that have not had the lock updates functionality from your plugin applied)?

    Original updates tab appears as so for reference:

    View post on imgur.com

    This way auto-update checks can still run, but have to manually triggered by viewing this tab, and this maintains the ability to obtain the increased performance by disabling TPUC(third party update checks) via your plugin. That’s the end result desired out of the feature by all correct? Disabling unnecessary update checks, but still having the plugins we do want to run checks be able to and easy access to the list of plugins with updates enabled in a centralized location.

    If i’m missing something, hopefully you can point me in the right direction. Thanks.

    • This reply was modified 4 years, 10 months ago by jazir5.
    • This reply was modified 4 years, 10 months ago by jazir5.
    • This reply was modified 4 years, 10 months ago by jazir5.
    • This reply was modified 4 years, 10 months ago by jazir5.
    • This reply was modified 4 years, 10 months ago by jazir5.
    • This reply was modified 4 years, 10 months ago by jazir5.
    Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    Code-wise, I’m not seeing anywhere indicating that we disallow access to the update areas for any part of the site. Not saying you’re not seeing a limited access, but is it possible you were using a non-admin user at that time? Closest I can think of is if a plugin was locked. We also don’t have any sort of default list of plugins for any sort of “can’t update these”. We want users of this plugin updating the plugins as needed.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Activating Maintainn Tools literally doubled my database queries in QM’ is closed to new replies.