REST Bug

Hi check2020de,

thanks for reporting a potential issue.

Are you saying that ISC seems to force the use of the REST API on your website or what do you mean by SUCCESS?

Which WordPress version and which editor (classic or block editor) are you using?

Thanks,
Thomas

Hi Thomas,

with SUCCESS I mean that the line in the GTMETRIX Waterfall chart is gone when I deactivate ISC (having REST deactivated bevor). Just deactivating REST doesn’t work, in this case the line in the waterall chart ist still there.

Here you can see the line:

https://dlgo.de/isc1.jpg
https://dlgo.de/isc2.jpg

I can togle this line on and off by activating and deactivating isc.

Best
Sven

• This reply was modified 5 years, 1 month ago by Anonymous User 17612203.
• This reply was modified 5 years, 1 month ago by Anonymous User 17612203.

Hi Sven,

thank you, I found it now and will try to dig deeper and see where it is coming from in the next days.

Thomas

Thanks Thomas!

Did I got you right, you where able to re-produce it on your server?

Hi check2020de,

yes, I saw the call to that file in the frontend of my test site which should give me a chance to find a solution.

Best regards,
Thomas

Great, thanks Thomas. I love this plugin realy and it looks like I can continuing using it ??

Hi Thomas,

any chance to solve it?

Best
Sven

Hi Sven, sorry, vacation and sickness currently prevent me from even thinking about it.
Best regards,
Thomas

Oh… get well soon and enjoy your vacation Thomas!

Hi Thommas,

hope you are doing well!? Have you had any channce to look deeper into it?

Cheers
Sven

Hi Sven,

still trying to get back to 100%, but on the way.

I wanted to have someone else to take a look at the issue since that part of the code was contributed by someone and not from me. Unfortunately, that didn’t happen.

I think I found the broken part of the code and my own tests look good. You would help me a lot if you could install the fixed version from https://github.com/webgilde/image-source-control/archive/i-36.zip and let me know if that a) fixes the issue and b) the ISC features in the backend, especially the options of the image block, are still working for you.

Thanks,
Thomas

Hi Thomas,

this sounds great. I’m happy to help, will test it later at home.

Best
Sven

Ok… can’t wait ?? Just did it with my mobile.

1. Deactivated isc
2. Installed and activated isc (your zip file)

Now I have 2 isc entries in my plugin list, one activated and one deactivated.

The issue is fixed and it looks like the options are working… I activated and deactivated “list below content”

What happens if I uninstall the plugin? Are the db entries deleted then or are they still exist and be there if I re-install isc?

• This reply was modified 5 years ago by Anonymous User 17612203.

Hi Sven, thanks for your feedback.

I will try to update the official version in the next days and then you can remove the debug version.

Uninstalling the plugin does not remove data.

Best regards,
Thomas

Thanks Thomas!