Couple of suggestions

  • Resolved wizzud

    (@wizzud)


    6 years, 6 months ago

    wrt v2.0.7

    1. GDPR_Public::set_plugin_cookies() currently sets [if not already set] allowed_cookies as being only those whose category status is ‘Required’. However, it should also include those whose category status is ‘ON’, otherwise (on first visit to a site) the allowed_cookies [cookie setting] and the Preference Center are inconsistent – the cookie says “not allowed”, the Preference Center says “allowed” (due to privacy-preferences-modal.php checking for the presence/absence of the privacy_bar cookie … which it shouldn’t).

    2. When electing to show the cookie categories in the Privacy Bar (privacy-bar.php), the category checkboxes should initially (ie. before any user action) show the current state of the settings. As for the Preference Center (see above), that ‘current state’ should reflect what allowed_cookies is set to.

    3. add a rule to assets/css/gdpr-public.css
    .gdpr-policies li a {box-sizing:border-box;}
    so that the padding around the Privacy Policy link doesn’t force a horizontal scroll bar in the sidebar of the Preference Center.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter wizzud

    (@wizzud)

    4. In privacy-bar.php, put the UL.gdpr-cookie-categories inside the if( $show_cookie_cat_checkboxes ) test (ie. don’t output the empty UL tags unless categories are being shown).

    Plugin Author Fernando Claussen

    (@fclaussen)

    Thank you!
    Enhancements like these are better suited as a GitHub issue. Easier for me to not lose track of them.

    1- On only means that the category is prechecked. I started looking into the privacy bar cookie because I was setting all the ONs to checked, the cookie allowed_cookies were set and if I moved to a different page, since the allowed_cookies cookie exists, the options that should be ON are now off.

    2- The checkboxes do follow what is on the privacy preference window. If you toggle one, it will toggle the other. However, since the bar is just for “first-time landing” I don’t need to check if the user already provided any preference in the past. All I need is to check what the default status of those categories should be (required, on, off)

    3- I don’t see this happening on my Mac but I believe that this might happen on Windows. Thank you.

    4- Thank you.

    Hy.

    One more thing.

    Have any chance to update plugin to work with older version of wordpress? I use some old site whict cannot be updated, and gdpr plugin wont save settings ??

    thx a lot

    Plugin Author Fernando Claussen

    (@fclaussen)

    I have no intentions of supporting prior versions. I’m sorry.

    Ok, i will modify plugin, found a hook in 215 line inside /wp-content/plugins/gdpr/admin/class-gdpr-admin.php
    and this line shoud be:
    register_setting( ‘gdpr’, $option_name, $sanitize_callback );

    Now work saving all setings in wp <4.7.

    I must test everithying else now.

    I thing this is good idea because many people have older version of wp, but update is for many very risky and expensive

    Plugin Author Fernando Claussen

    (@fclaussen)

    The issue is that we use sanitization functions that are only available from wp 4.7+.

    I understand that many people have older versions and updating might be expensive.

    But it is also expensive for me to do a free plugin to support the current version of WP. Imagine if I were to support old versions of WP and PHP.

    The best thing is for users to keep their installs up to date. The security fixes alone are enough to justify creating a backup of your current site, updating to see what happens on a staging environment, fixing problems and then updating in the production server.

    @raba : I remind you that the GDPR requires you to take all measures for the security of personal data, so the minimum is to have an updated WordPress.
    Or whatever you put up on your site to be in compliance will be useless.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Couple of suggestions’ is closed to new replies.