• Resolved markusfreise

    (@markusfreise-1)


    I found a bug that when you put the podcast_episode shortcode in a post that will also be featured in the feed, the feed shows the wrong posts.

    My podcast feed actually not showed my first podcast episode but my latest blog post.

    The reason is in line 1918 of the script class-ssp-frontend.php where you use a wp_reset_query which sets back the loop and results in ?wrong“ return values in the feed script.

    I hope this was helpful.

Viewing 12 replies - 1 through 12 (of 12 total)
  • Hello,

    We encounter the same issue.
    To add some details : we don’t create episodes. We set the podcast in the post itself, and in the shortcode we place in the post content, we use the ID of the post as episode ID.
    Regards,

    Vincent

    • This reply was modified 6 years, 7 months ago by vicente94.
    Plugin Author Craig Hewitt

    (@podcastmotor)

    Thanks to you both for your help and input with this bug. We’re working on a plugin release now for maybe this week and will look at including this fix in that release.

    If we can do anything else to help just let us know.
    Craig

    Thank you @markusfreise-1!
    I had this problem before and notified it but we could never pin point the issue… until now. ??

    Thread Starter markusfreise

    (@markusfreise-1)

    You are welcome. Thanks for this great plugin.

    Plugin Contributor Jonathan Bossenger

    (@psykro)

    Hi @markusfreise-1, @vicente94 and @fred-flq

    In order to properly understand the problem, could I ask this question, is there a specific reason you’re using the podcast_episode shortcode in a post that will also be featured in the feed, instead of simply adding the podcast meta data (file, duration etc) to the podcast enabled post?

    My assumption is that you are enabling Posts under the Podcast post types setting for Podcasts?

    Thanks

    H

    You’re right, posts are enabled under the podcast post types.

    We use shortcodes because neither the “above content” nor the “below content” media player position options fit our site layout: we need to have the player somewhere in the middle of the post.
    Then, you’ll probably suggest me to create podcast episodes and then to use their ID in the shortcode instead of the post ID itself. In this case the feed is correctly fed. The drawback is that the feed retrieves the title and the excerpt of the podcast episode, not the ones of the post where we inserted the shortcode. So we have to do twice the same job: same title for the post and the episode, same text content for the post and the episode.

    These are the reasons we use the shortcode in this way.
    Maybe your plugin has not been designed to be used in this way, which leads to the unexpected titles and excerpts in the feed. If it’s the case, I think it could be a great enhancement ??

    Regards,
    Vincent

    Note: hope I’m clear, English is not my mother tongue.

    Plugin Contributor Jonathan Bossenger

    (@psykro)

    Hello @vicente94, and thank you for your feedback.

    I agree that the plugin was not designed in this way, and it is for this reason that we recently added a new shortcode – [ss_player].

    Using this shortcode will allow you to embed the player anywhere inside your podcast (or post, if it is registered as a podcast).

    Maybe you would like to try this out and see if it resolves your requirement? If not please let me know and we can dig a little deeper.

    Regards

    Hello @psykro,

    Sorry for the late answer, I was on vacation during last week.

    I tried the [ss_player] shortcode and it fits our requirement, thank you.

    There’s only one point I have to discuss with our content manager but maybe you already have a solution: whatever the media player style we set in the parameters, the HTML5 player is always displayed when using this [ss_player] shortcode. Is there a way to change this to display the compact player?

    Regards,
    Vincent

    Hello again @psykro,

    Regarding the HTML5 player, is there a way to display the volume control?

    Regards,
    Vincent

    Plugin Contributor Jonathan Bossenger

    (@psykro)

    Hello @vicente94 thanks for your feedback.

    These are two very good points. Could I ask you to raise them as separate issues on the plugin’s GitHub repository: https://github.com/TheCraigHewitt/Seriously-Simple-Podcasting/issues

    Using the ss_player shortcode only renders the HTML5 player
    Ability to control volume in the HTML5 player

    That way we can track them and prioritise development.

    Thanks

    Hello @psykro,

    Thanks for your reply.
    I’ll raise these 2 issues on the plugin’s GitHub repository by the end of the day (currently 5PM here).

    Regards,
    Vincent

    • This reply was modified 6 years, 6 months ago by vicente94.
    Plugin Contributor Jonathan Bossenger

    (@psykro)

    Thank you.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘Bug for feed when you use a shortcode in the post’ is closed to new replies.